From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] fix #3976: api/backup: make schedule/starttime truly optional on update
Date: Fri, 1 Apr 2022 17:54:47 +0200 [thread overview]
Message-ID: <41a5afce-d792-10c8-4a0f-e597a109caa2@proxmox.com> (raw)
In-Reply-To: <20220401061413.702998-1-d.csapak@proxmox.com>
On 01.04.22 08:14, Dominik Csapak wrote:
> on create we require either starttime (+dow) or a schedule, but when
> updating an existing job, this is not necessary
>
> before we changed to schedules, the starttime was not optional either on
> update, but i think there is no reason to require the user to send the
> schedule/startime along every time.
>
> the gui will send all values every time, so that was never a problem there
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> PVE/API2/Backup.pm | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>
applied, thanks!
albeit the "$required" param name made me ask "required what?", but as the
check fn is "private" and small enough I don't think its a real code smell
issue.
prev parent reply other threads:[~2022-04-01 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 6:14 [pve-devel] " Dominik Csapak
2022-04-01 15:54 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41a5afce-d792-10c8-4a0f-e597a109caa2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox