Re: [pve-devel] [PATCH ha-manager 5/9] rules: resource affinity: decouple get_resource_affinity helper from Usage class

From: Fiona Ebner <f.ebner@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH ha-manager 5/9] rules: resource affinity: decouple get_resource_affinity helper from Usage class
Date: Mon, 20 Oct 2025 17:18:40 +0200	[thread overview]
Message-ID: <41443b75-98a6-4a48-afe4-22586474faa8@proxmox.com> (raw)
In-Reply-To: <DDKPPV7G511U.2IDPMPSSFCLCW@proxmox.com>

Am 17.10.25 um 5:46 PM schrieb Daniel Kral:
> On Fri Oct 17, 2025 at 1:14 PM CEST, Fiona Ebner wrote:
>> Am 30.09.25 um 4:21 PM schrieb Daniel Kral:
>>> diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm
>>> index 468e41eb..0226e427 100644
>>> --- a/src/PVE/HA/Manager.pm
>>> +++ b/src/PVE/HA/Manager.pm
>>> @@ -121,12 +121,12 @@ sub flush_master_status {
>>>  
>>>  =head3 select_service_node(...)
>>>  
>>> -=head3 select_service_node($rules, $online_node_usage, $sid, $service_conf, $sd, $node_preference)
>>> +=head3 select_service_node($rules, $online_node_usage, $sid, $service_conf, $ss, $node_preference)
>>>  
>>
>> Pre-existing, but is this duplicate heading intentional?
> 
> Yes, I picked it up from the Perl documentation RFC. This makes it
> easier to reference it in perlpod when one can use only the short
> heading instead of having to write out the heading with all of the
> parameters, while the latter will be used for the LSP AFAICT (which I
> actually don't use myself..).
> 
> L<< selects the service's node|/select_service_node(...) >>>
> 
> This one could be removed because currently it isn't used anywhere.

Oh, good to know! I was just wondering, I'm fine either way.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel