Re: [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64

[Matthias Heiserer <m.heiserer@proxmox.com>]

On 18.01.2023 15:07, Thomas Lamprecht wrote:
> for subject: s/GUI/ui/ to better match the predominantly used one.
> 
> Am 17/01/2023 um 13:17 schrieb Matthias Heiserer:
>> Sets the EFI version to 2m when arch=aarch64.
>>
>> When the VM has arch=aarch64, creating an EFI disk failed with
>> "Can't use an undefined value as an ARRAY reference at /usr/share/perl5/PVE/QemuServer.pm line 3382. (500)"
>>
>> That's because we only have EFI 2m available for aarch64.
>>
>> Reported in the forum: https://forum.proxmox.com/threads/121160/
>>
> 
> If we go this route I'd also enforce using the correct one when changing
> or creating VMs via the API.
When creating via the API (and not setting a type) the default is used, 
which works with aarch64. Only if 4m is explicitly set, it errors.
The ui user can't set the version, that's why I changed it there.

> 
> Two possible alternatives:
> - auto-select the existing one in the backend; drawback: if we ever add
>    another size for the AAVMF image we need to take extra/special care to
>    avoid breaking old systems. >
> - build also an AAVMF image with 4MB, but one would need to check if this
>    is really possible in the first place or if there are other drawbacks.
To me, the second option seems better, should it work.
I don't like the idea of letting the user provide a parameter and 
silently ignoring it.