public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH access-control 1/2] acl: allow more nesting for /mapping acl paths
Date: Fri, 10 Nov 2023 09:18:58 +0100	[thread overview]
Message-ID: <40f1858f-2294-4e60-9a93-319a5efdb4be@proxmox.com> (raw)
In-Reply-To: <20231107124607.571477-1-l.wagner@proxmox.com>

Am 07/11/2023 um 13:46 schrieb Lukas Wagner:
> This will be needed for ACL paths for the notification system,
> which will get separate namespaces for targets and matchers:
> 
> /mapping/notification/targets/<name>
> as well as
> /mapping/notification/matchers/<name>

Not that it matters much to this supporting patch, but above should all
use the singular, or? I.e., like "notification" also use "target" and
"matcher".

And it also feels a tad to fine-grained for me, but can be OK, maybe
someone else got an opinion on that (@Fabian?)




  parent reply	other threads:[~2023-11-10  8:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-07 12:46 Lukas Wagner
2023-11-07 12:46 ` [pve-devel] [PATCH manager 2/2] api: notifications: give targets and matchers their own ACL namespace Lukas Wagner
2023-11-10  8:18 ` Thomas Lamprecht [this message]
2023-11-10  8:47   ` [pve-devel] [PATCH access-control 1/2] acl: allow more nesting for /mapping acl paths Lukas Wagner
2023-11-13 15:41     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40f1858f-2294-4e60-9a93-319a5efdb4be@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal