From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>,
pve-devel@lists.proxmox.com, aderumier@odiso.com
Subject: Re: [pve-devel] [PATCH pve-common 1/1] schema: add pve-targetstorage (moved from qemu-server)
Date: Wed, 29 Jun 2022 11:48:26 +0200 [thread overview]
Message-ID: <40c84de7-c6b3-ce74-973d-bfe33c6e229d@proxmox.com> (raw)
In-Reply-To: <3e154f9b-7a7a-f0be-8bfb-614cb0a28c3a@proxmox.com>
On 29/06/2022 11:46, Fabian Ebner wrote:
> Am 29.06.22 um 11:34 schrieb Thomas Lamprecht:
>> this and "qemu-server: remove json schema pve-targetstorage (moved to pve-common)"
>> seems rather unrelated from the firewall series.
>>
>> Besides that I welcome splitting the Firewall.pm monster module up.
>>
>> For the record: the firewall part of this series needs a break/depends cycle:
>> - new firewall package needs to break old qemu-server and old pve-container
>> - new qemu-server and pve-container need a versioned dependency for new
>> pve-firewall
>>
>
> The targetstorage part of the series also needs the proper break/depends
> between qemu-server and common. Fabian G. already sent this before:
> https://lists.proxmox.com/pipermail/pve-devel/2022-February/051717.html
yeah sure, but as said, that part should be its own series.
next prev parent reply other threads:[~2022-06-29 9:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 9:08 [pve-devel] [PATCH SERIES common/firewall/qemu-server/container 0/1] Cleanup use of PVE::Firewall Alexandre Derumier
2022-06-29 9:08 ` [pve-devel] [PATCH qemu-server 1/2] api2: use firewall helpers Alexandre Derumier
2022-06-29 9:08 ` [pve-devel] [PATCH pve-firewall 1/1] move clone_vmfw_conf && remove_vmfw_conf to a Helpers Alexandre Derumier
2022-11-16 17:09 ` [pve-devel] applied: " Thomas Lamprecht
2022-06-29 9:08 ` [pve-devel] [PATCH pve-container 1/2] remove unused use PVE::Firewall Alexandre Derumier
2022-06-29 9:08 ` [pve-devel] [PATCH pve-common 1/1] schema: add pve-targetstorage (moved from qemu-server) Alexandre Derumier
2022-06-29 9:34 ` Thomas Lamprecht
2022-06-29 9:46 ` Fabian Ebner
2022-06-29 9:48 ` Thomas Lamprecht [this message]
2022-06-30 7:30 ` DERUMIER, Alexandre
2022-06-30 7:51 ` Thomas Lamprecht
2022-06-29 9:08 ` [pve-devel] [PATCH pve-container 2/2] api2 : use firewall helpers Alexandre Derumier
2022-06-29 9:08 ` [pve-devel] [PATCH qemu-server 2/2] qemu-server: remove json schema pve-targetstorage (moved to pve-common) Alexandre Derumier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40c84de7-c6b3-ce74-973d-bfe33c6e229d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=aderumier@odiso.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox