From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 4/4] parse vm config: remove "\s*" from multi-line comment regex
Date: Wed, 27 Apr 2022 11:21:33 +0200 [thread overview]
Message-ID: <408a5f27-d0e4-4d50-af50-b9e2cfead7f7@proxmox.com> (raw)
In-Reply-To: <20220224142151.3206908-4-s.sterz@proxmox.com>
On 24.02.22 15:21, Stefan Sterz wrote:
> To be consistent with PBS's implementation of multi-line comments
> remove "\s*" here too. Since the regex isn't lazy .* matches
> everything \s* would anyway. (Note that new lines occurs after "$").
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> PVE/QemuServer.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 243c2e5..79900e8 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -1,4 +1,4 @@
> -package PVE::QemuServer;
> +rpackage PVE::QemuServer;
^^^^ seems you fell on the keyboard there ;-) followed that up in git
next prev parent reply other threads:[~2022-04-27 9:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 14:21 [pve-devel] [PATCH cluster 1/4] parse datacenter config: remove "\s*" from " Stefan Sterz
2022-02-24 14:21 ` [pve-devel] [PATCH manager 2/4] parse node " Stefan Sterz
2022-02-24 14:21 ` [pve-devel] [PATCH container 3/4] parse pct config: remove "\s*" from multi-line " Stefan Sterz
2022-02-24 14:21 ` [pve-devel] [PATCH qemu-server 4/4] parse vm " Stefan Sterz
2022-04-27 9:21 ` Thomas Lamprecht [this message]
2022-04-27 6:56 ` [pve-devel] applied-series: [PATCH cluster 1/4] parse datacenter config: remove "\s*" from " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=408a5f27-d0e4-4d50-af50-b9e2cfead7f7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox