Re: [pve-devel] [PATCH v4 pve-storage 4/5] lvm: lvrename helper: allow path

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

> Alexandre Derumier via pve-devel <pve-devel@lists.proxmox.com> hat am 11.03.2025 11:28 CET geschrieben:


> Signed-off-by: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
> ---
>  src/PVE/Storage/LVMPlugin.pm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/src/PVE/Storage/LVMPlugin.pm b/src/PVE/Storage/LVMPlugin.pm
> index 19dbd7e..2431fcd 100644
> --- a/src/PVE/Storage/LVMPlugin.pm
> +++ b/src/PVE/Storage/LVMPlugin.pm
> @@ -365,9 +365,11 @@ sub lvcreate {
>  sub lvrename {
>      my ($vg, $oldname, $newname) = @_;
>  
> -    run_command(
> -	['/sbin/lvrename', $vg, $oldname, $newname],
> -	errmsg => "lvrename '${vg}/${oldname}' to '${newname}' error",
> +    my $cmd = ['/sbin/lvrename'];
> +    push @$cmd, $vg if $vg;
> +    push @$cmd, $oldname, $newname;
> +
> +    run_command($cmd, errmsg => "lvrename '${oldname}' to '${newname}' error",

why? see comments on other patches, I don't think we want or need this..

the call in qemu-server is forbidden as well, plugins are off-limits for non storage code..

>      );
>  }
>  
> -- 
> 2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel