From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-flutter-frontend 0/9] small improvements
Date: Tue, 16 Apr 2024 16:15:58 +0200 [thread overview]
Message-ID: <40453409-1831-4fd7-b375-5117a705250f@proxmox.com> (raw)
In-Reply-To: <20240412080458.1066580-1-d.csapak@proxmox.com>
Am 12/04/2024 um 10:04 schrieb Dominik Csapak:
> a series of smaller improvements, noticed by rechecking the app
> after updating to new dart/flutter version.
>
> not all of them have to be applied, most are rather independent.
> e.g. use of the NavigationBar, and the icon of the warning task logs are
> just my preferences.
>
> Dominik Csapak (9):
> replace BottomNavigationBar with NavigationBar
> resource tab: improve colors for headers
> node overview: don't throw permission errors on every update
> adapt to material 3 changes for themes
> fix clipping for data card widget
> set the color of the template indicator to that of the icon
> task logs: don't always say 'Last Task: '
> task logs: use separate color for warnings
> task log list: make warning icon more distinct
>
> lib/bloc/pve_node_overview_bloc.dart | 11 +++-
> lib/main.dart | 8 ++-
> lib/pages/main_layout_slim.dart | 62 ++++++++++---------
> lib/widgets/pve_guest_icon_widget.dart | 2 +-
> .../pve_resource_data_card_widget.dart | 2 +
> .../pve_task_log_expansiontile_widget.dart | 23 +++++--
> lib/widgets/pve_task_log_widget.dart | 5 +-
> 7 files changed, 74 insertions(+), 39 deletions(-)
>
applied series, thanks!
Made one follow-up to avoid suggesting that there are no updates
if the user did not have the permission to query that.
prev parent reply other threads:[~2024-04-16 14:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 8:04 [pve-devel] " Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 1/9] replace BottomNavigationBar with NavigationBar Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 2/9] resource tab: improve colors for headers Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 3/9] node overview: don't throw permission errors on every update Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 4/9] adapt to material 3 changes for themes Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 5/9] fix clipping for data card widget Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 6/9] set the color of the template indicator to that of the icon Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 7/9] task logs: don't always say 'Last Task: ' Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 8/9] task logs: use separate color for warnings Dominik Csapak
2024-04-12 8:04 ` [pve-devel] [PATCH pve-flutter-frontend 9/9] task log list: make warning icon more distinct Dominik Csapak
2024-04-16 14:15 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40453409-1831-4fd7-b375-5117a705250f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox