Re: [PATCH perlmod 2/4] value: implement serde::de::IntoDeserializer on Value

[Wolfgang Bumiller <w.bumiller@proxmox.com>]

On Mon, Jul 20, 2026 at 05:25:38PM +0200, Max R. Carrara wrote:
> For better compatibility with serde, we implement
> `serde::de::IntoDeserializer` on `Value`. This allows us to skip
> explicitly converting to the `Value` deserializer in `perlmod::de`.
> 
> Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
> ---
>  perlmod-macro/src/function.rs | 2 +-
>  perlmod/src/value.rs          | 9 +++++++++
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/perlmod-macro/src/function.rs b/perlmod-macro/src/function.rs
> index 0a4cf0e..8b5d689 100644
> --- a/perlmod-macro/src/function.rs
> +++ b/perlmod-macro/src/function.rs
> @@ -136,7 +136,7 @@ impl ArgumentAttrs {
>                      let _guard = ::perlmod::__private__::InParameterDeserialization::guard();
>                      match <#arg_type as ::perlmod::__private__::serde::Deserialize>::deserialize(
>                          ::perlmod::__private__::serde::de::value::SeqDeserializer::new(
> -                            #extracted_name.map(::perlmod::de::Deserializer::<'static>::from_value)
> +                            #extracted_name
>                          )
>                      ) {
>                          Ok(arg) => arg,
> diff --git a/perlmod/src/value.rs b/perlmod/src/value.rs
> index 1240eb5..5c2d432 100644
> --- a/perlmod/src/value.rs
> +++ b/perlmod/src/value.rs
> @@ -3,6 +3,7 @@
>  
>  use std::fmt;
>  
> +use serde::de::IntoDeserializer;

For a single-use I'd rather skip the import.

That said, if we do this at all, one might wonder whether `&'de Value`
should also be IntoDeserializer (via `de::from_ref_value`).

>  use serde::{Deserialize, Serialize};
>  
>  use crate::Error;
> @@ -652,3 +653,11 @@ impl<'de> Deserialize<'de> for Value {
>          }
>      }
>  }
> +
> +impl<'de> IntoDeserializer<'de, Error> for Value {
> +    type Deserializer = crate::de::Deserializer<'de>;
> +
> +    fn into_deserializer(self) -> Self::Deserializer {
> +        Self::Deserializer::from_value(self)
> +    }
> +}
> -- 
> 2.47.3
> 
> 
> 
> 
> 

--