Re: [PATCH pve-manager 2/5] notifications: Add refresh-targets endpoint

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Wed, Feb 11, 2026 at 10:49:45AM +0100, Lukas Wagner wrote:
> On Wed Feb 4, 2026 at 5:13 PM CET, Arthur Bied-Charreton wrote:
> > This endpoint allows triggering a refresh of the notification targets'
> > state, e.g., to prevent OAuth2 refresh tokens from expiring.
> >
> > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> > ---
> >  PVE/API2/Cluster/Notifications.pm | 34 +++++++++++++++++++++++++++++++
> >  1 file changed, 34 insertions(+)
> >
> > diff --git a/PVE/API2/Cluster/Notifications.pm b/PVE/API2/Cluster/Notifications.pm
> > index a45a15b2..f993817d 100644
> > --- a/PVE/API2/Cluster/Notifications.pm
> > +++ b/PVE/API2/Cluster/Notifications.pm
> > @@ -321,6 +321,40 @@ __PACKAGE__->register_method({
> >      },
> >  });
> >  
> > +__PACKAGE__->register_method({
> > +    name => "refresh_targets",
> > +    path => 'refresh-targets',
> 
> Same note here regarding naming, I think 'refresh-targets' is a bit too
> generic for my taste. Either we fully narrow it down to
> 'refresh-oauth-tokens', or make it rather general, e.g.
> 'trigger-periodic-maintenance' (or something similar, you get the
> general direction), covering the case that *maybe* some other endpoint
> could need some periodic action as well.
> 
You're right, the naming is kind of a WIP.. Maybe something 
like 'trigger-state-refresh' would make sense? 'refresh-oauth-tokens'
is a bit too narrow imo, we would have to change it/add a new one again 
if proxmox-notify needs more state in the future

> Also, do have any plans of exposing this in the GUI somehow? It's
> definitely nice to have this available via pvesh for manual
> troubleshooting by an admin anyways, so the API endpoint makes sense;
> but as far as I can tell you do not use this endpoint anywhere in the
> GUI code; hence I'm asking.
> 
I don't mean to use it in the UI no, it is intended for pvesh