From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings
Date: Mon, 22 Apr 2024 15:18:21 +0200 [thread overview]
Message-ID: <3ff3ecf6-08b5-49fb-8d6f-84448ff32b78@proxmox.com> (raw)
In-Reply-To: <2d790314-0973-4cf1-937e-00041cf8b0bf@proxmox.com>
On 4/22/24 15:13, Fiona Ebner wrote:
> Am 15.04.24 um 10:50 schrieb Markus Frank:
>> ---
>> www/manager6/qemu/MachineEdit.js | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/www/manager6/qemu/MachineEdit.js b/www/manager6/qemu/MachineEdit.js
>> index 48c72c1d..ee2b2dac 100644
>> --- a/www/manager6/qemu/MachineEdit.js
>> +++ b/www/manager6/qemu/MachineEdit.js
>> @@ -1,6 +1,7 @@
>> Ext.define('PVE.qemu.MachineInputPanel', {
>> extend: 'Proxmox.panel.InputPanel',
>> xtype: 'pveMachineInputPanel',
>> + onlineHelp: 'qm_system_settings',
>>
>
> Why not the more accurate 'qm_machine_type' (was introduced in pve-docs
>> = 8.1.0)?
>
>
you're right, would be even better (did not realize that existed), i/you can send/push a follow up?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-04-22 13:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 8:50 [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox Markus Frank
2024-04-15 8:50 ` [pve-devel] [PATCH manager v10 2/2] ui: machine: add link to documentation of the system settings Markus Frank
2024-04-22 13:13 ` Fiona Ebner
2024-04-22 13:18 ` Dominik Csapak [this message]
2024-04-22 13:19 ` Fiona Ebner
2024-04-22 13:21 ` Thomas Lamprecht
2024-04-22 13:22 ` Dominik Csapak
2024-04-22 13:11 ` [pve-devel] [PATCH manager v10 1/2] ui: machine: add viommu ComboBox Fiona Ebner
2024-04-22 13:16 ` Dominik Csapak
2024-04-22 13:24 ` Fiona Ebner
2024-04-22 17:58 ` Thomas Lamprecht
2024-04-22 13:11 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ff3ecf6-08b5-49fb-8d6f-84448ff32b78@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox