From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/2] migration: avoid crash with heavy IO on local VM disk
Date: Thu, 23 May 2024 11:29:47 +0200 [thread overview]
Message-ID: <3f7943f0-8983-4992-9149-1f9520354041@proxmox.com> (raw)
In-Reply-To: <1716455155.i5mq0p043i.astroid@yuna.none>
Am 23/05/2024 um 11:08 schrieb Fabian Grünbichler:
>> + my $kvm_version = PVE::QemuServer::kvm_user_version();
> wouldn't this need to check the *running* qemu binary for the migrated
> VM, not the *installed* qemu binary on the system?
Yes, this would need to check the running QEMU version via QMP,
as otherwise, the new command will be also get issued to VMs
started before the updated, which then will fail.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-05-23 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 8:34 Fiona Ebner
2024-05-03 8:34 ` [pve-devel] [PATCH qemu-server 2/2] migration: add missing use statements Fiona Ebner
2024-05-23 9:03 ` [pve-devel] applied: " Fabian Grünbichler
2024-05-28 7:50 ` Fiona Ebner
2024-05-23 9:08 ` [pve-devel] [PATCH qemu-server 1/2] migration: avoid crash with heavy IO on local VM disk Fabian Grünbichler
2024-05-23 9:29 ` Thomas Lamprecht [this message]
2024-05-28 8:01 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f7943f0-8983-4992-9149-1f9520354041@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox