From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Leo Nunner <l.nunner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 storage] fix #3004: show progress of offline migration in task log
Date: Thu, 31 Aug 2023 15:25:10 +0200 [thread overview]
Message-ID: <3f33bb26-bee2-437f-8c86-ddece2a448af@proxmox.com> (raw)
In-Reply-To: <20230831104159.119407-1-l.nunner@proxmox.com>
Am 31/08/2023 um 12:41 schrieb Leo Nunner:
> dd supports a 'status' flag, which enables it to show the copied bytes,
> duration, and the transfer rate, which then get printed to stderr.
>
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> Changes since v2:
> - Refactor to new repo structure
> - Implement style changes suggested for v2
>
> src/PVE/Storage.pm | 17 +++++++++++++++--
> src/PVE/Storage/LVMPlugin.pm | 2 +-
> src/PVE/Storage/Plugin.pm | 4 ++--
> 3 files changed, 18 insertions(+), 5 deletions(-)
>
>
applied, thanks!
fyi: instead of the comments I moved the $1 capture group into a $elapsed
$variable, which makes the code IMO descriptive enough without those comments.
Didn't felt that this small style nit would warrant asking a follow up from
you, so applied that directly.
prev parent reply other threads:[~2023-08-31 13:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 10:41 [pve-devel] " Leo Nunner
2023-08-31 13:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f33bb26-bee2-437f-8c86-ddece2a448af@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox