Re: [pve-devel] [PATCH qemu-server 10/10] test: cfg2cmd: don't use QEMU binary version less than 8.0 for tests

[Fiona Ebner <f.ebner@proxmox.com>]

Am 06.09.24 um 16:39 schrieb Daniel Kral:
> Another small misspelling that could be corrected here:
> 
> s/depreacation/deprecation
> 
> On Tue, 23 Jul 2024 17:25:40 +0200, Fiona Ebner wrote:
>> diff --git a/test/cfg2cmd/cputype-icelake-client-deprecation.conf b/test/cfg2cmd/cputype-icelake-client-deprecation.conf
>> index 523dd275..2f595162 100644
>> --- a/test/cfg2cmd/cputype-icelake-client-deprecation.conf
>> +++ b/test/cfg2cmd/cputype-icelake-client-deprecation.conf
>> @@ -1,5 +1,4 @@
>>  # TEST: test CPU type depreacation for Icelake-Client (never existed in the wild)
> 
> Otherwise, I haven't found anything to add to the changes and the test
> cases are all passing on my machine as expected.
> 
> Therefore:
> 
> Reviewed-by: Daniel Kral <d.kral@proxmox.com>
> Tested-by: Daniel Kral <d.kral@proxmox.com>
> 

Thank you for the review/testing!

Note (for the future): If the tags here are supposed to be for the whole
series, it would be customary to add them in a reply to the cover letter.

Feel free to send patches for the pre-existing typos you found. You
might want to wait until my series got applied to avoid merge-conflicts.
If there's going to be a v2 of my series for some reason, I can also add
them as follow-ups myself.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel