Re: [pve-devel] [PATCH storage 1/2] rbd: remove no longer used rados_cmd helper

[Aaron Lauterer <a.lauterer@proxmox.com>]

tested both patches:
* list contents
* snapshot & rollback & delete snapshot of a VM
* add new disk, detach & delete
* move-disk

Consider these two patches

Reviewed-By: Aaron Lauterer <a.lauterer@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

On  2025-04-22  10:56, Fabian Grünbichler wrote:
> all librados interaction is now via our XS binding, the last usage was
> removed in 41aacc6cdeea9b0c8007cbfb280acf827932c3d6
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>   src/PVE/Storage/RBDPlugin.pm | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/src/PVE/Storage/RBDPlugin.pm b/src/PVE/Storage/RBDPlugin.pm
> index c78db00..162c016 100644
> --- a/src/PVE/Storage/RBDPlugin.pm
> +++ b/src/PVE/Storage/RBDPlugin.pm
> @@ -124,12 +124,6 @@ my $rbd_cmd = sub {
>       return $build_cmd->('/usr/bin/rbd', $scfg, $storeid, $op, @options);
>   };
>   
> -my $rados_cmd = sub {
> -    my ($scfg, $storeid, $op, @options) = @_;
> -
> -    return $build_cmd->('/usr/bin/rados', $scfg, $storeid, $op, @options);
> -};
> -
>   # needed for volumes created using ceph jewel (or higher)
>   my $krbd_feature_update = sub {
>       my ($scfg, $storeid, $name) = @_;



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel