* [pve-devel] [PATCH qemu-server] migrate: fix memory migration start time
@ 2021-04-23 12:31 Fabian Ebner
2021-04-23 13:14 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2021-04-23 12:31 UTC (permalink / raw)
To: pve-devel
The variable is only ever used for calculating the average speed of memory
migration, but it was set before disk mirroring already. But the disk
sizes are not included in the calculation, resulting in (very) wrong values.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/QemuMigrate.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 6455182..e9bcade 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE/QemuMigrate.pm
@@ -929,8 +929,6 @@ sub phase2 {
$self->log('info', "start remote tunnel");
$self->start_remote_tunnel($raddr, $rport, $ruri, $unix_socket_info);
- my $start = time();
-
if ($self->{storage_migration}) {
$self->{storage_migration_jobs} = {};
$self->log('info', "starting storage migration");
@@ -1025,6 +1023,8 @@ sub phase2 {
}
+ my $start = time();
+
$self->log('info', "start migrate command to $ruri");
eval {
mon_cmd($vmid, "migrate", uri => $ruri);
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu-server] migrate: fix memory migration start time
2021-04-23 12:31 [pve-devel] [PATCH qemu-server] migrate: fix memory migration start time Fabian Ebner
@ 2021-04-23 13:14 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-04-23 13:14 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 23.04.21 14:31, Fabian Ebner wrote:
> The variable is only ever used for calculating the average speed of memory
> migration, but it was set before disk mirroring already. But the disk
> sizes are not included in the calculation, resulting in (very) wrong values.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuMigrate.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-23 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-23 12:31 [pve-devel] [PATCH qemu-server] migrate: fix memory migration start time Fabian Ebner
2021-04-23 13:14 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox