Re: [pve-devel] [PATCH v2] log: add perlmod logger

[Gabriel Goller <g.goller@proxmox.com>]

On 05.12.2024 14:37, Lukas Wagner wrote:
>
>
>On  2024-12-05 14:17, Gabriel Goller wrote:
>>> Minor nit: repo in the subject prefix is missing, also the order of patches should probably reversed.
>>
>> Happens when you don't use murpp, am I right? :)
>>
>>> Seems to work fine, now messages logged by proxmox-notify while being in task context show up
>>> in the task logs again. Only downside to this approach is that we now also log to stderr
>>> in regular daemon (non-task) context? I don't think this is an issue tho?
>>
>> I think we nearly always call perlmod functions in tasks anyway so it
>> should be fine. Worst case is you get duplicated errors in the journal
>> (i.e. stderr routed to journal and normal journal print).
>>
>
>Thinking about notifications, we have
>  - backup jobs -> task context
>  - package-update -> no task
>  - fencing -> no task
>  - storage-replication -> no task IIRC
>
>So at least for notifications, the majority does not run in task context.
>
>Anyway, afaik we don't redirect stderr to the journal in PVE, so we shouldn't
>even get any duplicated messages. I think stdout/stderr is only visible
>if you run pvedaemon/pveproxy in foreground. At least that's how I remember
>it :D

Hmm I need to test this, systemd afaik redirects stderr to journald
automatically... In a task context stderr gets rerouted though.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel