From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] test: migrate: correctly mock storage module
Date: Mon, 8 Feb 2021 16:26:05 +0100 [thread overview]
Message-ID: <3e2870df-22e7-5fe2-d0f5-681e52ad8741@proxmox.com> (raw)
In-Reply-To: <20210208142603.24149-1-f.ebner@proxmox.com>
On 08.02.21 15:26, Fabian Ebner wrote:
> by fixing a typo. Since cfs_read_file within the storage module was not mocked,
> the tests could fail on some setups. Now that get_bandwidth_limit is mocked,
> cfs_read_file is not called anymore, but still mock it too for good measure and
> to make it more future-proof.
>
> Reported-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> test/MigrationTest/Shared.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-02-08 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 14:26 [pve-devel] " Fabian Ebner
2021-02-08 15:26 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e2870df-22e7-5fe2-d0f5-681e52ad8741@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox