From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit 1/1] move pbsEncryptionCheckbox from pve-manager
Date: Wed, 28 Oct 2020 17:09:05 +0100 [thread overview]
Message-ID: <3da5cb19-e868-b208-4e92-83b84470868a@proxmox.com> (raw)
In-Reply-To: <20201028152222.25023-2-s.ivanov@proxmox.com>
On 28.10.20 16:22, Stoiko Ivanov wrote:
> for reuse in PMG
>
I'd rather fix this first in PVE, currently it provides a horrendous UX...
We want to:
* allow uploading a key
* explicitly warn about the importance when auto-generating one and provide
and easy download and paper-key button.
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/Makefile | 1 +
> src/form/PBSEncryptionCheckbox.js | 63 +++++++++++++++++++++++++++++++
> 2 files changed, 64 insertions(+)
> create mode 100644 src/form/PBSEncryptionCheckbox.js
>
> diff --git a/src/Makefile b/src/Makefile
> index cd0bf26..3e10e9d 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -31,6 +31,7 @@ JSSRC= \
> form/RoleSelector.js \
> form/DiskSelector.js \
> form/MultiDiskSelector.js \
> + form/PBSEncryptionCheckbox.js \
> button/Button.js \
> button/HelpButton.js \
> grid/ObjectGrid.js \
> diff --git a/src/form/PBSEncryptionCheckbox.js b/src/form/PBSEncryptionCheckbox.js
> new file mode 100644
> index 0000000..35c6950
> --- /dev/null
> +++ b/src/form/PBSEncryptionCheckbox.js
> @@ -0,0 +1,63 @@
> +Ext.define('Proxmox.form.PBSEncryptionCheckbox', {
> + extend: 'Ext.form.field.Checkbox',
> + xtype: 'pbsEncryptionCheckbox',
> +
> + inputValue: true,
> +
> + viewModel: {
> + data: {
> + value: null,
> + originalValue: null,
> + },
> + formulas: {
> + blabel: (get) => {
> + let v = get('value');
> + let original = get('originalValue');
> + if (!get('isCreate') && original) {
> + if (!v) {
> + return gettext('Warning: Existing encryption key will be deleted!');
> + }
> + return gettext('Active');
> + } else {
> + return gettext('Auto-generate a client encryption key, saved privately on cluster filesystem');
PMG has no cluster filesystem?
> + }
> + },
> + },
> + },
> +
> + bind: {
> + value: '{value}',
> + boxLabel: '{blabel}',
> + },
> + resetOriginalValue: function() {
> + let me = this;
> + let vm = me.getViewModel();
> + vm.set('originalValue', me.value);
> +
> + me.callParent(arguments);
> + },
> +
> + getSubmitData: function() {
> + let me = this;
> + let val = me.getSubmitValue();
> + if (!me.isCreate) {
> + if (val === null) {
> + return { 'delete': 'encryption-key' };
> + } else if (val && !!val !== !!me.originalValue) {
> + return { 'encryption-key': 'autogen' };
> + }
> + } else if (val) {
> + return { 'encryption-key': 'autogen' };
> + }
> + return null;
> + },
> +
> + initComponent: function() {
> + let me = this;
> + me.callParent();
> +
> + let vm = me.getViewModel();
> + vm.set('isCreate', me.isCreate);
> + },
> +});
> +
>
next prev parent reply other threads:[~2020-10-28 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 15:22 [pve-devel] [PATCH widget-toolkit/manager] move PBSEncryptionCheckbox to proxmox-widget-toolkit Stoiko Ivanov
2020-10-28 15:22 ` [pve-devel] [PATCH widget-toolkit 1/1] move pbsEncryptionCheckbox from pve-manager Stoiko Ivanov
2020-10-28 16:09 ` Thomas Lamprecht [this message]
2020-10-28 15:22 ` [pve-devel] [PATCH manager 1/1] remove pbsEncryptionCheckbox Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3da5cb19-e868-b208-4e92-83b84470868a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox