From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] NetworkEdit: allow setting 'mtu' option for guest network devices
Date: Wed, 9 Feb 2022 19:03:34 +0100 [thread overview]
Message-ID: <3d9039a7-02c7-27bd-588c-c7fe41001380@proxmox.com> (raw)
In-Reply-To: <20220207121825.722340-1-o.bektas@proxmox.com>
commit subject should rather be
"ui: vm network: allow to override mtu for virtio devices"
On 07.02.22 13:18, Oguz Bektas wrote:
> we already have the 'mtu' option inside the API, so we can just expose
> that option inside the 'Advanced' menu for guest network interfaces.
We have that property since commit 61a14cde8d568e552d3deaab2da76b479b8aca7b but
it's only effective for when the VirtIO driver is used. The ui should reflect
that as it may get really confusing for users with e1000(e) or other non-virtio
models. MTU changes are notoriously tricky as it needs to be right in the whole
network path, so the UX is IMO important for this
next prev parent reply other threads:[~2022-02-09 18:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 12:18 Oguz Bektas
2022-02-07 13:45 ` Dylan Whyte
2022-02-09 18:03 ` Thomas Lamprecht [this message]
2022-02-10 10:10 ` Oguz Bektas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d9039a7-02c7-27bd-588c-c7fe41001380@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox