public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 manager 2/2] ui: lxc: add edit window for device passthrough
Date: Tue, 16 Apr 2024 13:48:36 +0200	[thread overview]
Message-ID: <3d8a7b91-0478-42ae-969a-55f5502289df@proxmox.com> (raw)
In-Reply-To: <650d700c-2fad-4a37-9010-e0cc53aca05d@proxmox.com>

On 15/04/2024 14:12, Fiona Ebner wrote:
>> +
>> +    advancedColumn2: [
>> +	{
>> +	    xtype: 'textfield',
>> +	    name: 'mode',
>> +	    editable: true,
>> +	    fieldLabel: gettext('Access Mode'),
>> +	    emptyText: '0660',
>> +	    labelAlign: 'right',
>> +	    validator: function(value) {
>> +		if (/^0[0-7]{3}$|^$/i.test(value)) {
> Should we require the leading zero here? Many users will be familiar
> with chown, where it is not required.

We already require the access mode to have a leading zero in
pve-container.





  reply	other threads:[~2024-04-16 11:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 15:03 [pve-devel] [PATCH v3 manager 0/2] " Filip Schauer
2024-01-31 15:03 ` [pve-devel] [PATCH v3 manager 1/2] utils: clarify naming of LXC mount point utils Filip Schauer
2024-04-15 12:12   ` Fiona Ebner
2024-01-31 15:03 ` [pve-devel] [PATCH v3 manager 2/2] ui: lxc: add edit window for device passthrough Filip Schauer
2024-04-15 12:12   ` Fiona Ebner
2024-04-16 11:48     ` Filip Schauer [this message]
2024-04-16 12:10 ` [pve-devel] [PATCH v3 manager 0/2] " Filip Schauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d8a7b91-0478-42ae-969a-55f5502289df@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal