public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager 0/3] Use Autoscaler instead of Autoscale on user-facing strings
@ 2023-11-24 13:03 Maximiliano Sandoval
  2023-11-24 13:03 ` [pve-devel] [PATCH manager 1/3] ceph-pool: Add gettext to user-facing string Maximiliano Sandoval
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Maximiliano Sandoval @ 2023-11-24 13:03 UTC (permalink / raw)
  To: pve-devel

The autoscaler is well-known Ceph concept. A translation might prefer to use
"Autoscaler" as-is in a translation, which in turn lends itself better to a
search online.

The patch series is split into three commits since each one can be a bit more
controvertial than the last one.

Maximiliano Sandoval (3):
  ceph-pool: Add gettext to user-facing string
  ceph-pool: Replace PG Autoscale with PG Autoscaler on user-facing
    string
  ceph-pool: Replace Autoscale with Autoscaler in user-facing string

 www/manager6/ceph/Pool.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.39.2





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [pve-devel] [PATCH manager 1/3] ceph-pool: Add gettext to user-facing string
  2023-11-24 13:03 [pve-devel] [PATCH manager 0/3] Use Autoscaler instead of Autoscale on user-facing strings Maximiliano Sandoval
@ 2023-11-24 13:03 ` Maximiliano Sandoval
  2023-11-24 13:03 ` [pve-devel] [PATCH manager 2/3] ceph-pool: Replace PG Autoscale with PG Autoscaler on " Maximiliano Sandoval
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Maximiliano Sandoval @ 2023-11-24 13:03 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/ceph/Pool.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index c61d4f71..e514518c 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -88,7 +88,7 @@ Ext.define('PVE.CephPoolInputPanel', {
     column2: [
 	{
 	    xtype: 'proxmoxKVComboBox',
-	    fieldLabel: 'PG Autoscale Mode',
+	    fieldLabel: gettext('PG Autoscale Mode'),
 	    name: 'pg_autoscale_mode',
 	    comboItems: [
 		['warn', 'warn'],
-- 
2.39.2





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [pve-devel] [PATCH manager 2/3] ceph-pool: Replace PG Autoscale with PG Autoscaler on user-facing string
  2023-11-24 13:03 [pve-devel] [PATCH manager 0/3] Use Autoscaler instead of Autoscale on user-facing strings Maximiliano Sandoval
  2023-11-24 13:03 ` [pve-devel] [PATCH manager 1/3] ceph-pool: Add gettext to user-facing string Maximiliano Sandoval
@ 2023-11-24 13:03 ` Maximiliano Sandoval
  2023-11-24 13:03 ` [pve-devel] [PATCH manager 3/3] ceph-pool: Replace Autoscale with Autoscaler in " Maximiliano Sandoval
  2024-11-12 19:35 ` [pve-devel] applied: [PATCH manager 0/3] Use Autoscaler instead of Autoscale on user-facing strings Thomas Lamprecht
  3 siblings, 0 replies; 5+ messages in thread
From: Maximiliano Sandoval @ 2023-11-24 13:03 UTC (permalink / raw)
  To: pve-devel

The autoscaler is well-known Ceph concept. A translation might prefer to
use "Autoscaler" as-is in a translation.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/ceph/Pool.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index e514518c..116d9eb3 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -88,7 +88,7 @@ Ext.define('PVE.CephPoolInputPanel', {
     column2: [
 	{
 	    xtype: 'proxmoxKVComboBox',
-	    fieldLabel: gettext('PG Autoscale Mode'),
+	    fieldLabel: gettext('PG Autoscaler Mode'),
 	    name: 'pg_autoscale_mode',
 	    comboItems: [
 		['warn', 'warn'],
-- 
2.39.2





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [pve-devel] [PATCH manager 3/3] ceph-pool: Replace Autoscale with Autoscaler in user-facing string
  2023-11-24 13:03 [pve-devel] [PATCH manager 0/3] Use Autoscaler instead of Autoscale on user-facing strings Maximiliano Sandoval
  2023-11-24 13:03 ` [pve-devel] [PATCH manager 1/3] ceph-pool: Add gettext to user-facing string Maximiliano Sandoval
  2023-11-24 13:03 ` [pve-devel] [PATCH manager 2/3] ceph-pool: Replace PG Autoscale with PG Autoscaler on " Maximiliano Sandoval
@ 2023-11-24 13:03 ` Maximiliano Sandoval
  2024-11-12 19:35 ` [pve-devel] applied: [PATCH manager 0/3] Use Autoscaler instead of Autoscale on user-facing strings Thomas Lamprecht
  3 siblings, 0 replies; 5+ messages in thread
From: Maximiliano Sandoval @ 2023-11-24 13:03 UTC (permalink / raw)
  To: pve-devel

The autoscaler is well-known Ceph concept. A translation might prefer to
use "Autoscaler" as-is in a translation.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/ceph/Pool.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js
index 116d9eb3..16479fee 100644
--- a/www/manager6/ceph/Pool.js
+++ b/www/manager6/ceph/Pool.js
@@ -370,7 +370,7 @@ Ext.define('PVE.node.Ceph.PoolList', {
 	    },
 	},
 	{
-	    text: gettext('Autoscale Mode'),
+	    text: gettext('Autoscaler Mode'),
 	    flex: 1,
 	    minWidth: 100,
 	    align: 'right',
-- 
2.39.2





^ permalink raw reply	[flat|nested] 5+ messages in thread

* [pve-devel] applied: [PATCH manager 0/3] Use Autoscaler instead of Autoscale on user-facing strings
  2023-11-24 13:03 [pve-devel] [PATCH manager 0/3] Use Autoscaler instead of Autoscale on user-facing strings Maximiliano Sandoval
                   ` (2 preceding siblings ...)
  2023-11-24 13:03 ` [pve-devel] [PATCH manager 3/3] ceph-pool: Replace Autoscale with Autoscaler in " Maximiliano Sandoval
@ 2024-11-12 19:35 ` Thomas Lamprecht
  3 siblings, 0 replies; 5+ messages in thread
From: Thomas Lamprecht @ 2024-11-12 19:35 UTC (permalink / raw)
  To: Proxmox VE development discussion, Maximiliano Sandoval

Am 24.11.23 um 14:03 schrieb Maximiliano Sandoval:
> The autoscaler is well-known Ceph concept. A translation might prefer to use
> "Autoscaler" as-is in a translation, which in turn lends itself better to a
> search online.
> 
> The patch series is split into three commits since each one can be a bit more
> controvertial than the last one.
> 
> Maximiliano Sandoval (3):
>   ceph-pool: Add gettext to user-facing string
>   ceph-pool: Replace PG Autoscale with PG Autoscaler on user-facing
>     string
>   ceph-pool: Replace Autoscale with Autoscaler in user-facing string
> 
>  www/manager6/ceph/Pool.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 


applied series but squashed them into a single patch, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-11-12 19:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-24 13:03 [pve-devel] [PATCH manager 0/3] Use Autoscaler instead of Autoscale on user-facing strings Maximiliano Sandoval
2023-11-24 13:03 ` [pve-devel] [PATCH manager 1/3] ceph-pool: Add gettext to user-facing string Maximiliano Sandoval
2023-11-24 13:03 ` [pve-devel] [PATCH manager 2/3] ceph-pool: Replace PG Autoscale with PG Autoscaler on " Maximiliano Sandoval
2023-11-24 13:03 ` [pve-devel] [PATCH manager 3/3] ceph-pool: Replace Autoscale with Autoscaler in " Maximiliano Sandoval
2024-11-12 19:35 ` [pve-devel] applied: [PATCH manager 0/3] Use Autoscaler instead of Autoscale on user-facing strings Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal