From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pve-devel] [PATCH common 2/2] REST environment: default to 'root@pam' for forked workers in case no user was specified
Date: Fri, 11 Mar 2022 09:00:50 +0100 [thread overview]
Message-ID: <3cd2e74f-ba04-1f71-083d-98a58915a578@proxmox.com> (raw)
In-Reply-To: <99d70393-8e7d-e44b-277b-36879906cd3f@proxmox.com>
Am 10.03.22 um 13:01 schrieb Fabian Ebner:
> Am 07.03.22 um 10:20 schrieb Oguz Bektas:
>> + if (!defined($user)) {
>> + warn 'Worker user was not specified, defaulting to "root@pam"!';
>
> Could mention that it's an internal error. And could use $self->warn().
Shouldn't use $self->warn(), because the warning here won't show up in
the task log and it'd be very confusing to have a non-zero warning count
without warning.
prev parent reply other threads:[~2022-03-11 8:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 9:20 [pve-devel] [PATCH pve-container 1/2] pct: set worker user for pull_file/push_file calls Oguz Bektas
2022-03-07 9:20 ` [pve-devel] [PATCH common 2/2] REST environment: default to 'root@pam' for forked workers in case no user was specified Oguz Bektas
2022-03-10 12:01 ` Fabian Ebner
2022-03-11 8:00 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cd2e74f-ba04-1f71-083d-98a58915a578@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox