From: Daniel Kral <d.kral@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] applied: [PATCH esxi-import-tools 1/2] listvms: add check for vCLS test whether vm configuration is present
Date: Fri, 25 Apr 2025 09:38:15 +0200 [thread overview]
Message-ID: <3c8648d0-dabb-4ded-ae8d-c04080d1ab19@proxmox.com> (raw)
In-Reply-To: <174551596005.4030446.11729269108713478737.b4-ty@proxmox.com>
On 4/24/25 19:33, Thomas Lamprecht wrote:
> Applied, but I had to make a followup for the second patch, which had a
> logical error that was even reported on package build:
>
> ---
> mypy listvms.py
> listvms.py:261: error: "None" has no attribute "extraConfig" [attr-defined]
> ---
>
> Would be great if you could end to end test changes.
Yes, I'm sorry, I should have catched that before sending the patch. I
will take more care for future patches.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-25 7:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 15:06 [pve-devel] " Daniel Kral
2025-04-11 15:06 ` [pve-devel] [RFC esxi-import-tools 2/2] listvms: add message when skipping vCLS agent VMs Daniel Kral
2025-04-11 15:45 ` Max Carrara
2025-04-24 17:33 ` [pve-devel] applied: [PATCH esxi-import-tools 1/2] listvms: add check for vCLS test whether vm configuration is present Thomas Lamprecht
2025-04-25 7:38 ` Daniel Kral [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c8648d0-dabb-4ded-ae8d-c04080d1ab19@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal