From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2] fix #3815: influxdb vmname should be string
Date: Fri, 28 Jan 2022 07:08:32 +0100 [thread overview]
Message-ID: <3c729f28-c8e9-0ca4-a7a8-35be5bb98c47@proxmox.com> (raw)
In-Reply-To: <20220127125255.65105-1-m.frank@proxmox.com>
On 27.01.22 13:52, Markus Frank wrote:
> InfluxDB interprets the vmname 66601 as a number and the vmname vm42 as a String.
> This leads to problematic metrics, that will be dropped by influxdb.
> Whichever comes first decides how the "schema" is defined.
>
> To change that I added a $quoted hashmap to quote a value.
> In this case the value of name.
>
> nodename and host are tags in InfluxDB so the only value they are able
> to contain are strings:
ah great, thanks for clearing that up to me!
Some more comments because it seems I only checked out surrounding code more
closely now, argh.
> https://docs.influxdata.com/influxdb/v2.1/reference/syntax/line-protocol/
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> PVE/Status/InfluxDB.pm | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/PVE/Status/InfluxDB.pm b/PVE/Status/InfluxDB.pm
> index def7e2fd..d63e18ac 100644
> --- a/PVE/Status/InfluxDB.pm
> +++ b/PVE/Status/InfluxDB.pm
> @@ -276,6 +276,7 @@ sub test_connection {
> sub build_influxdb_payload {
> my ($class, $txn, $data, $ctime, $tags, $excluded, $measurement, $instance) = @_;
>
can we add a small comment here, something like:
# 'abc' and '123' are both valid hostnames, that confuses influx's type detection
> + my $quoted = { name => 1 };
> my @values = ();
>
> foreach my $key (sort keys %$data) {
> @@ -283,6 +284,10 @@ sub build_influxdb_payload {
> my $value = $data->{$key};
> next if !defined($value);
>
> + if (defined($quoted) && $quoted->{$key}) {
The defined check is not required anymore as we always define that variable
locally now.
> + $value =~ s/\"/\\\"/g;
> + $value = "\"$value\"";
> + }
so this actually looks quite Ok, but when wanting to finally apply this I saw
some other opportunity, namely, we already got prepare_value and it can already
quote, so instead of doing the quoting manually above we could add a $force_quote
(or something in that spirit) parameter and then just call it like:
prepare_value($value, $to_quote->{$key})
prev parent reply other threads:[~2022-01-28 6:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 12:52 Markus Frank
2022-01-28 6:08 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c729f28-c8e9-0ca4-a7a8-35be5bb98c47@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox