public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Markus Frank <m.frank@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v16 4/12] control: add virtiofsd as runtime dependency for qemu-server
Date: Mon, 7 Apr 2025 14:03:49 +0200	[thread overview]
Message-ID: <3c6099b6-8327-48bd-a08a-c63f5030b00f@proxmox.com> (raw)
In-Reply-To: <8ac83b86-2442-4e5b-b49c-e44801a1a8b4@proxmox.com>



On  2025-04-07 14:00, Thomas Lamprecht wrote:
> Am 07.04.25 um 12:59 schrieb Markus Frank:
>> On  2025-04-07 12:43, Thomas Lamprecht wrote:
>>> Would your code handle the case where the executable does not exist
>>> with a somewhat nice error?
>> No, it does not.
>>
>> But it can easily be added.
>>    
>> diff --git a/PVE/QemuServer/Virtiofs.pm b/PVE/QemuServer/Virtiofs.pm
>> index 5b948d57..6c9018e5 100644
>> --- a/PVE/QemuServer/Virtiofs.pm
>> +++ b/PVE/QemuServer/Virtiofs.pm
>> @@ -163,6 +163,9 @@ sub start_virtiofsd {
>>        my $dir_cfg = PVE::Mapping::Dir::find_on_current_node($virtiofs->{dirid});
>>    
>>        my $virtiofsd_bin = '/usr/libexec/virtiofsd';
>> +    if (! -f $virtiofsd_bin) {
>> +       print "virtiofsd is not installed. To use virtio-fs, install virtiofsd via apt.\n";
> 
> s/print/die/, I'd think? Or at least log_warn + early return.
Yes, should be a die. My mistake.
> 
> And could you send a v17 with that changed? Maybe also the
> UI proposal from Filip (please talk with Dominik about if that
> would be fine in general)
Okay, I will do that.



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-04-07 12:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 16:08 [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v16 0/12] virtiofs Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH cluster v16 1/12] add mapping/dir.cfg for resource mapping Markus Frank
2025-04-04 17:03   ` [pve-devel] applied: " Thomas Lamprecht
2025-04-04 16:08 ` [pve-devel] [PATCH guest-common v16 2/12] add dir mapping section config Markus Frank
2025-04-07  9:58   ` [pve-devel] applied: " Thomas Lamprecht
2025-04-04 16:08 ` [pve-devel] [PATCH docs v16 3/12] add doc section for the shared filesystem virtio-fs Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH qemu-server v16 4/12] control: add virtiofsd as runtime dependency for qemu-server Markus Frank
2025-04-07 10:43   ` Thomas Lamprecht
2025-04-07 10:59     ` Markus Frank
2025-04-07 12:00       ` Thomas Lamprecht
2025-04-07 12:03         ` Markus Frank [this message]
2025-04-04 16:08 ` [pve-devel] [PATCH qemu-server v16 5/7] fix #1027: virtio-fs support Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH qemu-server v16 6/12] migration: check_local_resources for virtiofs Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH qemu-server v16 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH manager v16 08/12] api: add resource map api endpoints for directories Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH manager v16 09/12] ui: add edit window for dir mappings Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH manager v16 10/12] ui: add resource mapping view for directories Markus Frank
2025-04-07  9:51   ` Filip Schauer
2025-04-04 16:08 ` [pve-devel] [PATCH manager v16 11/12] ui: form: add selector for directory mappings Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH manager v16 12/12] ui: add options to add virtio-fs to qemu config Markus Frank
2025-04-07 12:03   ` Filip Schauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c6099b6-8327-48bd-a08a-c63f5030b00f@proxmox.com \
    --to=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal