public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] tree-wide: add serde `derive` where actually needed
Date: Tue, 12 Nov 2024 14:51:35 +0100	[thread overview]
Message-ID: <3c14095f-7689-464b-89b0-cf354afb1b8c@proxmox.com> (raw)
In-Reply-To: <20241112125000.583271-1-c.heiss@proxmox.com>

Am 12.11.24 um 13:49 schrieb Christoph Heiss:
> Fixes building each crate on their own.
> 
> In a full build (e.g. `make deb`), everything pulls in serde with the
> `derive` feature anyway and thus does not exihibit any build failures.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Only noticed this by pure chance while using `cargo test -p
> proxmox-tui-installer`. Interesting though that a full build does not
> break, which is why I didn't notice it until now ..
> 
>  proxmox-installer-common/Cargo.toml | 2 +-
>  proxmox-post-hook/Cargo.toml        | 2 +-
>  proxmox-tui-installer/Cargo.toml    | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2024-11-12 13:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-12 12:49 [pve-devel] " Christoph Heiss
2024-11-12 13:51 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c14095f-7689-464b-89b0-cf354afb1b8c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal