Re: [pve-devel] [PATCH installer] tui: Add a cancel button to Advanced bootdisk options

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 21/06/2023 um 11:16 schrieb Maximiliano Sandoval:
> This matches the GUI installer which counts with a close (x) button.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  proxmox-tui-installer/src/views/bootdisk.rs | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/proxmox-tui-installer/src/views/bootdisk.rs b/proxmox-tui-installer/src/views/bootdisk.rs
> index 3fdbe5b..eaf343d 100644
> --- a/proxmox-tui-installer/src/views/bootdisk.rs
> +++ b/proxmox-tui-installer/src/views/bootdisk.rs
> @@ -456,6 +456,7 @@ fn advanced_options_view(disks: &[Disk], options: Rc<RefCell<BootdiskOptions>>)
>          &(*options).borrow(),
>      ))
>      .title("Advanced bootdisk options")
> +    .dismiss_button("Cancel")

meh, this focuses first, before the Ok button, which is just makes the existing
non-ideal UX w.r.t. focus priority of buttons worse, so for now I rather have no
such button - user can simply press OK, which is also a bit easier to have a
clear understanding that the entered values are actually the ones then used.
As with a cancel we really need to ensure that no callback has already changed
data, not sure for the TUI, but the GTK UI would need quite some extra handling
here.

>      .button("Ok", {
>          let options_ref = options.clone();
>          move |siv| {