From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 manager] pve7to8: Improve systemd unified cgroupv2 support check
Date: Mon, 12 Jun 2023 16:46:51 +0200 [thread overview]
Message-ID: <3ae76307-ad99-8d44-8424-bf3b593a6503@proxmox.com> (raw)
In-Reply-To: <20230612103113.40308-1-c.ebner@proxmox.com>
Am 12/06/2023 um 12:31 schrieb Christian Ebner:
> Checking /lib/systemd if it is present and a directory is not enough, as
> the shared object file used to check the version might nevertheless be
> located at /usr/lib/systemd, or under /usr/lib/x86_64-linux-gnu/systemd.
> So check also the latter paths, if the former returned no match.
>
> Further, Arch Linux appends the minor version and release version to the
> filename, so include that in the regex as well.
>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Changes since v1:
> - Also check for shared object in /usr/lib/x86_64-linux-gnu/systemd
>
> PVE/CLI/pve7to8.pm | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
>
applied, tranformed into a loop in a follow up though, thanks!
fwiw, we have some experimental support for ARM/RSIC-V containers via the
binfmt_misc + qemu mechanism, but those are not fully supported for now
so I think it's ok to ignore that here...
prev parent reply other threads:[~2023-06-12 14:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 10:31 [pve-devel] " Christian Ebner
2023-06-12 14:46 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ae76307-ad99-8d44-8424-bf3b593a6503@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox