From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] fix #4435: devices list: avoid error for undefined value
Date: Wed, 11 Jan 2023 10:15:11 +0100 [thread overview]
Message-ID: <3acbb1e8-a890-0b69-9926-d4d9142d4428@proxmox.com> (raw)
In-Reply-To: <20230110134137.185361-1-f.ebner@proxmox.com>
Am 10/01/2023 um 14:41 schrieb Fiona Ebner:
> When $d->{'pci_bridge'}->{devices} is undef, @-dereferencing it will
> die with:
>> Can't use an undefined value as an ARRAY reference
>
> This can happen (at least) when the VM is in 'prelaunch' state. The
> QAPI definition for '@PciBridgeInfo' also declares the 'devices'
> member as optional.
>
> Before commit 721624b ("collect device list for nested pci-bridges"),
> there was no issue, because $d->{'pci_bridge'}->{devices} was used in
> foreach, so auto-vivified if undef.
>
> Fixes: f721624b ("collect device list for nested pci-bridges")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-01-11 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 13:41 [pve-devel] " Fiona Ebner
2023-01-11 9:15 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3acbb1e8-a890-0b69-9926-d4d9142d4428@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox