From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] assistant: error out on set network config for dhcp
Date: Tue, 23 Apr 2024 18:31:58 +0200 [thread overview]
Message-ID: <3ab1b7d2-1427-4604-964b-b3d8db5fc9e2@proxmox.com> (raw)
In-Reply-To: <20240423151806.2665929-1-s.ivanov@proxmox.com>
Am 23/04/2024 um 17:18 schrieb Stoiko Ivanov:
> potentially will not happen too often in practice if the sample files
> always contain the right source. Still having settings in an answer
> file that get ignored does not seem right.
>
> tested with `validate-answer` on a file without `source` in the
> network section (which initially caused confusion for me)
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> proxmox-auto-installer/src/answer.rs | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
>
applied, thanks!
I'm wonder if we should allow filtering by management NIC for the DHCP case
too though (in the long term).
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-23 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 15:18 [pve-devel] " Stoiko Ivanov
2024-04-23 16:31 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ab1b7d2-1427-4604-964b-b3d8db5fc9e2@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox