From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH container 1/2] net: Add `link_down` config to allow setting interfaces as disconnected
Date: Tue, 14 Feb 2023 10:52:15 +0100 [thread overview]
Message-ID: <3aac0a5d-ce0b-747e-1b16-ed3e70489edb@proxmox.com> (raw)
In-Reply-To: <20230213135700.502195-2-c.heiss@proxmox.com>
On 13/02/2023 14:56, Christoph Heiss wrote:
> + link_down => {
> + type => 'boolean',
> + description => 'Whether this interface should be disconnected (like pulling the plug).',
> + optional => 1,
> + },
I'd prefer using kebab-case over snake_case for new properties, or do
we really gain anything here (e.g., qemu-server related infra reuse?)
besides from that, the patch here contains quite some unrelated whitespace
changes, please avoid that.
next prev parent reply other threads:[~2023-02-14 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 13:56 [pve-devel] [PATCH container/manager 0/2] fix #3413: Add `Disconnect` option for LXC networks Christoph Heiss
2023-02-13 13:56 ` [pve-devel] [PATCH container 1/2] net: Add `link_down` config to allow setting interfaces as disconnected Christoph Heiss
2023-02-13 14:31 ` Wolfgang Bumiller
2023-02-14 9:29 ` Christoph Heiss
2023-02-14 9:52 ` Thomas Lamprecht [this message]
2023-02-14 10:10 ` Christoph Heiss
2023-02-14 10:20 ` Thomas Lamprecht
2023-02-13 13:57 ` [pve-devel] [PATCH manager 2/2] lxc: Add `Disconnect` option for network interfaces Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aac0a5d-ce0b-747e-1b16-ed3e70489edb@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox