Re: [pve-devel] [PATCH perl-rs v4 1/1] fix #4234: openid: adjust openid verification function for userinfo option

[Mira Limbeck <m.limbeck@proxmox.com>]

On 3/24/25 04:37, Thomas Skinner wrote:
> Signed-off-by: Thomas Skinner <thomas@atskinner.net>
> ---
>  pve-rs/src/openid/mod.rs | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/pve-rs/src/openid/mod.rs b/pve-rs/src/openid/mod.rs
> index 1fa7572..095ef26 100644
> --- a/pve-rs/src/openid/mod.rs
> +++ b/pve-rs/src/openid/mod.rs
> @@ -54,9 +54,14 @@ mod export {
>          #[try_from_ref] this: &OpenId,
>          code: &str,
>          private_auth_state: PrivateAuthState,
> +        query_userinfo: Option<bool>,
>      ) -> Result<Value, Error> {
>          let open_id = this.inner.lock().unwrap();
> -        let claims = open_id.verify_authorization_code_simple(code, &private_auth_state)?;
> +        let claims = open_id.verify_authorization_code_simple_userinfo(
> +            code,
> +            &private_auth_state,
> +            query_userinfo.unwrap_or(true),
> +        )?;
>  
>          Ok(to_value(&claims)?)
>      }

As mentioned in my reply to version v3, the code has changed in commit
`9ee9ad4` which moved the code to common/src/oidc.
Please rebase this patch on top of the current proxmox-perl-rs master
branch.
You'll have to make changes in both common/src/oidc as well as
pve-rs/src/openid/mod.rs.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel