From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-network 1/1] ipam: netbox: fix adding vms without a name set in the options
Date: Tue, 8 Apr 2025 15:29:20 +0200 [thread overview]
Message-ID: <3a726979-6d4c-4869-9309-53009ed8f189@proxmox.com> (raw)
In-Reply-To: <20250408132517.225240-1-s.hanreich@proxmox.com>
Am 08.04.25 um 15:25 schrieb Stefan Hanreich:
> The hostname provided to the methods in the IPAM plugins is empty for
> VMs that do not have a name set. We always included the dns_name key
> in the request, even if it was undefined, which leads Netbox to return
> a 400 Bad Request error. With this patch we omit the dns_name
> parameter if it isn't set, so the call succeeds.
We default to "CT${VMID}" and "VM${VMID}" in that case though everywhere
such a hostname is required, that does not make sense here, or?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-08 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 13:25 Stefan Hanreich
2025-04-08 13:29 ` Thomas Lamprecht [this message]
2025-04-08 13:32 ` Stefan Hanreich
2025-04-08 13:37 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a726979-6d4c-4869-9309-53009ed8f189@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal