Re: [pve-devel] [PATCH proxmx-nvidia-vgpu-helper 2/2] add script to help with the installation of the nvidia vgpu dependencies

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 02.12.24 um 09:47 schrieb Dominik Csapak:
> What I'd have imagined is more like our 'pveceph' tool that can
> include multiple commands, even if we might only have one or two for now
> 
> so e.g.
> 
> pve-nvidia-vgpu-helper install-prerequisites

Yes, that was my idea as well, but I'd just do above for now, all else can follow,
let's not blow up the scope here for the initial implementation.

> pve-nvidia-vgpu-helper gpus list
> pve-nvidia-vgpu-helper gpus enable-sriov
> etc..

> thir
> 
> * not sure about that, but couldn't this be a rust binary?

Not sure if it wins us much here, it certainly has it's cost too, and for such
simple things it does not always balance out, like having to rebuild it on
bigger toolchain changes to profit from them and do not cause issues on major
upgrades; a interpreted language avoids that and perl is an OK choice here.
Also, Hannes already re-wrote this from bash to perl, let's not make him run in
circles. If it really becomes a problem to use perl, which I doubt, then it can
be still re-written later on, which is as much work as doing it now but then
has some actual arguments for making that worthwhile.

> i think we have everything we need already there.
> It is not a requirement for this IMHO, but personally i tend to write new things
> in rust these days.
> 
> * it would be very nice to also have some general prerequisites checked, maybe
> as a separate command or all-in-one (does not matter much imo). For example
> if iommu/vt-d/etc. is turned on and the cards are separated, if there are even
> nvidia cards installed, etc.

IMO it does matter quite a bit, installing base-line software support and doing
basic checks are very different things, I'd not couple those unconditionally.
As it's odd that one cannot prepare a host by installing the basic package set
if it IOMMU is turned off, why force a reboot there? The other way is also a bit
odd to try to install stuff if one just wants to check if they meet some basic
checks (after doing some changes to HW, kernel cmdline, ...).

So please do those in different commands, and the basic checks can be nice to have
but I'd really focus on the command to install the basic package set first.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel