From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 container 2/2] close #3471: Support for NetworkManager on CentOS.
Date: Thu, 17 Jun 2021 14:58:54 +0200 [thread overview]
Message-ID: <3a4f3dea-4fa6-e919-568b-33f047956b39@proxmox.com> (raw)
In-Reply-To: <1623933097.d1qp4xibda.astroid@nora.none>
On 6/17/21 14:33, Fabian Grünbichler wrote:
> On June 17, 2021 2:28 pm, Dominik Csapak wrote:
>>> my $bootproto = '';
>>>
>>> @@ -213,7 +214,7 @@ sub setup_network {
>>> if ($d->{ip6} eq 'auto') {
>>> $data .= "IPV6_AUTOCONF=yes\n";
>>> }
>>> - if ($d->{ip6} eq 'dhcp') {
>>> + elsif ($d->{ip6} eq 'dhcp') {
>>
>> this change does nothing?
>
> it changes the condition for the else branch below (previously, ip6 ==
> auto would take it, now it does not - see the bug report).
ah yes thanks^^
stared at it for a few minutes and did not see it...
>
>>
>>> $data .= "DHCPV6C=yes\n";
>>> } else {
>>> $data .= "IPV6ADDR=$d->{ip6}\n";
>>> @@ -229,6 +230,15 @@ sub setup_network {
>>> }
>>> }
prev parent reply other threads:[~2021-06-17 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 18:23 [pve-devel] [PATCH v2 container 1/2] CentOS6 is obsolete. Tests renamed to centos7 Denis Knauf
2021-06-16 18:23 ` [pve-devel] [PATCH v2 container 2/2] close #3471: Support for NetworkManager on CentOS Denis Knauf
2021-06-17 12:28 ` Dominik Csapak
2021-06-17 12:33 ` Fabian Grünbichler
2021-06-17 12:58 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a4f3dea-4fa6-e919-568b-33f047956b39@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox