[pve-devel] [PATCH qemu-server] vzdump: improve error logging for query-proxmox-support

[pve-devel] [PATCH qemu-server] vzdump: improve error logging for query-proxmox-support

[Stefan Reiter]

Only show "not supported by QEMU version" message if we determine that
to be the actual cause, just print the error otherwise.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
 PVE/VZDump/QemuServer.pm | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 5a9ffab..4d171d2 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -490,9 +490,15 @@ sub archive_pbs {
 	};
 
 	my $qemu_support = eval { mon_cmd($vmid, "query-proxmox-support") };
-	if (!$qemu_support) {
-	    die "PBS backups are not supported by the running QEMU version. Please make "
-	      . "sure you've installed the latest version and the VM has been restarted.\n";
+	my $err = $@;
+	if (!$qemu_support || $err) {
+	    die "query-proxmox-support returned empty value\n" if !$err;
+	    if ($err =~ m/The command query-proxmox-support has not been found/) {
+		die "PBS backups are not supported by the running QEMU version. Please make "
+		  . "sure you've installed the latest version and the VM has been restarted.\n";
+	    } else {
+		die "QMP command query-proxmox-support failed - $err\n";
+	    }
 	}
 
 	my $fs_frozen = $self->qga_fs_freeze($task, $vmid);
-- 
2.20.1

[pve-devel] applied: [PATCH qemu-server] vzdump: improve error logging for query-proxmox-support

[Thomas Lamprecht]

On 17.03.21 11:19, Stefan Reiter wrote:
> Only show "not supported by QEMU version" message if we determine that
> to be the actual cause, just print the error otherwise.
> 
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>  PVE/VZDump/QemuServer.pm | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
>

applied, thanks!