* [pve-devel] [PATCH qemu-server] vzdump: improve error logging for query-proxmox-support
@ 2021-03-17 10:19 Stefan Reiter
2021-03-24 5:54 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Reiter @ 2021-03-17 10:19 UTC (permalink / raw)
To: pve-devel
Only show "not supported by QEMU version" message if we determine that
to be the actual cause, just print the error otherwise.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
PVE/VZDump/QemuServer.pm | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 5a9ffab..4d171d2 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -490,9 +490,15 @@ sub archive_pbs {
};
my $qemu_support = eval { mon_cmd($vmid, "query-proxmox-support") };
- if (!$qemu_support) {
- die "PBS backups are not supported by the running QEMU version. Please make "
- . "sure you've installed the latest version and the VM has been restarted.\n";
+ my $err = $@;
+ if (!$qemu_support || $err) {
+ die "query-proxmox-support returned empty value\n" if !$err;
+ if ($err =~ m/The command query-proxmox-support has not been found/) {
+ die "PBS backups are not supported by the running QEMU version. Please make "
+ . "sure you've installed the latest version and the VM has been restarted.\n";
+ } else {
+ die "QMP command query-proxmox-support failed - $err\n";
+ }
}
my $fs_frozen = $self->qga_fs_freeze($task, $vmid);
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu-server] vzdump: improve error logging for query-proxmox-support
2021-03-17 10:19 [pve-devel] [PATCH qemu-server] vzdump: improve error logging for query-proxmox-support Stefan Reiter
@ 2021-03-24 5:54 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-03-24 5:54 UTC (permalink / raw)
To: Proxmox VE development discussion, Stefan Reiter
On 17.03.21 11:19, Stefan Reiter wrote:
> Only show "not supported by QEMU version" message if we determine that
> to be the actual cause, just print the error otherwise.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
> PVE/VZDump/QemuServer.pm | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-24 5:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 10:19 [pve-devel] [PATCH qemu-server] vzdump: improve error logging for query-proxmox-support Stefan Reiter
2021-03-24 5:54 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox