From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Mira Limbeck <m.limbeck@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] fix drive-mirror completion with cloudinit
Date: Mon, 25 Jan 2021 14:31:00 +0100 [thread overview]
Message-ID: <39ffc619-4d7c-8f87-8992-adb6150868fc@proxmox.com> (raw)
In-Reply-To: <20210115114924.30795-1-m.limbeck@proxmox.com>
On 15.01.21 12:49, Mira Limbeck wrote:
> On clone_vm when cloning the disks while the VM is running, we use
> drive-mirror. We skip completion until the last disk, but with a
> cloudinit disk there's no drive-mirror and so no completion done. If it
> is the last disk in the hash, we never complete the drive-mirror jobs
> and no further cloning is possible as there are already active jobs
> using the disks.
>
> To fix it we have to call qemu_drive_mirror_monitor directly in the case
> of cloudinit when completion is requested and there are jobs defined.
>
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> PVE/QemuServer.pm | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2021-01-25 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 11:49 [pve-devel] " Mira Limbeck
2021-01-25 13:31 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39ffc619-4d7c-8f87-8992-adb6150868fc@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox