From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting
Date: Wed, 20 Sep 2023 14:10:29 +0200 [thread overview]
Message-ID: <398db91c-0244-4a0d-912a-73c77333939a@proxmox.com> (raw)
In-Reply-To: <20230907094942.74479-1-m.sandoval@proxmox.com>
sadly removing these parameters would be a breaking change
i'd rather mark it deprecatedand non-functional in the description
and remove the functionality
then on the next major release, we can announce the breaking change and
remove the parameter
On 9/7/23 11:49, Maximiliano Sandoval wrote:
> This setting was removed in [1] as part of the v13.0.2 tag.
>
> [1] https://github.com/ceph/ceph/commit/e6acf2d1d528a2395947d446a57bec04a3a002dc
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> I did a grep search across multiple projects and I was not able to find
> more uses of this option. A second pair of eyes might help here.
>
> PVE/API2/Ceph.pm | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/PVE/API2/Ceph.pm b/PVE/API2/Ceph.pm
> index 7e0763cf..a4101dee 100644
> --- a/PVE/API2/Ceph.pm
> +++ b/PVE/API2/Ceph.pm
> @@ -158,16 +158,6 @@ __PACKAGE__->register_method ({
> minimum => 1,
> maximum => 7,
> },
> - pg_bits => {
> - description => "Placement group bits, used to specify the " .
> - "default number of placement groups.\n\nNOTE: 'osd pool " .
> - "default pg num' does not work for default pools.",
> - type => 'integer',
> - default => 6,
> - optional => 1,
> - minimum => 6,
> - maximum => 14,
> - },
> disable_cephx => {
> description => "Disable cephx authentication.\n\n" .
> "WARNING: cephx is a security feature protecting against " .
> @@ -224,11 +214,6 @@ __PACKAGE__->register_method ({
> $cfg->{client}->{keyring} = '/etc/pve/priv/$cluster.$name.keyring';
> }
>
> - if ($param->{pg_bits}) {
> - $cfg->{global}->{'osd pg bits'} = $param->{pg_bits};
> - $cfg->{global}->{'osd pgp bits'} = $param->{pg_bits};
> - }
> -
> if ($param->{network}) {
> $cfg->{global}->{'public network'} = $param->{network};
> $cfg->{global}->{'cluster network'} = $param->{network};
next prev parent reply other threads:[~2023-09-20 12:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 9:49 Maximiliano Sandoval
2023-09-07 9:49 ` [pve-devel] [PATCH manager 2/2] ceph: api: use snake_case when setting options Maximiliano Sandoval
2023-09-20 12:10 ` Dominik Csapak [this message]
2023-09-20 13:21 ` [pve-devel] [PATCH manager 1/2] ceph: remove global pg bits setting Thomas Lamprecht
2023-09-20 13:42 ` Maximiliano Sandoval
2023-09-20 14:27 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=398db91c-0244-4a0d-912a-73c77333939a@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox