From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Andreas Neufert <Andreas.Neufert@veeam.com>
Subject: Re: [pve-devel] [Veeam] Veeam change requests?
Date: Thu, 19 Sep 2024 09:53:53 +0200 [thread overview]
Message-ID: <39504c85-1fbb-44a3-850c-0d8132c01c09@proxmox.com> (raw)
In-Reply-To: <mailman.275.1726558174.414.pve-devel@lists.proxmox.com>
On 9/17/24 09:20, Andreas Neufert via pve-devel wrote:
>
> Hi Proxmox Dev team,
>
Hi,
> Tim Marx mentioned that you have some insights and change wishes for the Veeam backup processing and that we should reach out to this list. We would be happy to get this feedback here to be able to address it in our code or join a call if this helps.
Thanks for reaching out!
During (very basic & short) testing, i discovered a few things that are problematic from our point
of view:
* During backup, there is often a longer running connection open to our QMP socket of running VMs
(/var/run/qemu-server/XXXX.qmp, where XXXX is the vmid). This blocks our management stack from
doing certain tasks, like start/stop (probably does not matter during backup) but also
things like the VNC console, etc.
a better way would be to close the connections as soon as possible instead of keeping them
open. (Alternatively using our API/CLI could also be done, but I don't know what
exact QMP commands you're running)
if you absolutely need a longer running socket, please open a bug report on
https://bugzilla.proxmox.com so we can discuss and track that there, how we could make
a socket available that is not used by our stack
* Another thing that I noticed was that it's not really visible if a backup is running
for a particular VM, so users might accidentally them down (or pause, etc.). Especially
i think it's bad if the VM is placed under a HA policy that has 'stopped' as target, as
that will try to stop the VM by itself. (Though this might be a configuration error in itself?)
A quick way to fix this would be to have a (custom) lock in our VMs. For longer running tasks
that block a guest, we have a line 'lock: XXXX' in the config that prevents our stack
from doing most operations.
Putting that in would be a very short call to our perl code that locks the config locally
( `PVE::QemuConfig->lock_config($vmid, $updatefn) ), checks for existing locks,
updates the config with a new (custom) lock and writes it again.
Though i must admit, I'm not sure if custom locks outside of our defined ones would work,
but I'm sure we could add a 'custom' lock that you could use, should my mentioned
approach not work properly.
* Also, I noticed that when a guest is started from your stack, you modify the QEMU command line a
bit, namely removing some options that would be necessary to start the VM during the backup.
Is there a specific reason why you do it this way, instead of starting the VM through
our API/CLI?
A more general question last: What is the process for our/your users and us if they/we
find a bug? Where can they be reported to you?
I hope this helps
Best regards
Dominik
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-09-19 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-17 7:20 Andreas Neufert via pve-devel
2024-09-19 7:53 ` Dominik Csapak [this message]
2024-09-19 8:40 ` Andreas Neufert via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39504c85-1fbb-44a3-850c-0d8132c01c09@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=Andreas.Neufert@veeam.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox