From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v3 pve-network 0/5] SDN: Add mocking to run tests in sbuild
Date: Thu, 4 Apr 2024 16:23:48 +0200 [thread overview]
Message-ID: <394c6d86-e713-4d77-8f88-31bf4c15ce5d@proxmox.com> (raw)
In-Reply-To: <20240402110740.291710-3-s.lendl@proxmox.com>
Tested building this with sbuild - completed successfully (including tests).
I've also checked out the changes and tested them by creating a new EVPN
zone and setting a local frr config. Everything still seems to be
working as before.
Consider this:
Tested-By: Stefan Hanreich <s.hanreich@proxmox.com>
On 4/2/24 13:07, Stefan Lendl wrote:
> Extract and mock functions that otherwise access system files which is not
> possible in a clean sbuild environment.
> Namely /etc/network/interfaces as well as /etc/frr/frr.config.local
> Added .gitignore for sbuild artifacts
>
> Changes v2 -> v3:
> * Changed commit messages according to commit guide lines
> * Not importing Dumper in zones test
> * Re-Enabled DNS tests
> * Added .gitignore which was previously a separate patch
>
> Changes v1 -> v2:
> * Disabled DNS tests because they fail
>
>
> Stefan Lendl (5):
> controllers: extract read_etc_network_interfaces
> evpn: extract read_local_frr_config
> tests: mocking more functions to avoid system access
> tests: run tests in sbuild
> gitignore: build artifacts from sbuild
>
> .gitignore | 3 ++
> src/Makefile | 2 +-
> src/PVE/Network/SDN/Controllers.pm | 16 +++++++---
> src/PVE/Network/SDN/Controllers/EvpnPlugin.pm | 10 ++++--
> src/test/run_test_zones.pl | 31 +++++++++++++++++++
> 5 files changed, 54 insertions(+), 8 deletions(-)
>
next prev parent reply other threads:[~2024-04-04 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 11:07 Stefan Lendl
2024-04-02 11:07 ` [pve-devel] [PATCH v3 pve-network 1/5] controllers: extract read_etc_network_interfaces Stefan Lendl
2024-04-02 11:07 ` [pve-devel] [PATCH v3 pve-network 2/5] evpn: extract read_local_frr_config Stefan Lendl
2024-04-02 11:07 ` [pve-devel] [PATCH v3 pve-network 3/5] tests: mocking more functions to avoid system access Stefan Lendl
2024-04-02 11:07 ` [pve-devel] [PATCH v3 pve-network 4/5] tests: run tests in sbuild Stefan Lendl
2024-04-02 11:07 ` [pve-devel] [PATCH v3 pve-network 5/5] gitignore: build artifacts from sbuild Stefan Lendl
2024-04-04 14:23 ` Stefan Hanreich [this message]
2024-04-04 14:51 ` [pve-devel] applied-series: [PATCH v3 pve-network 0/5] SDN: Add mocking to run tests in sbuild Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=394c6d86-e713-4d77-8f88-31bf4c15ce5d@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox