From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v2 0/3] Add first welcome screen
Date: Thu, 10 Dec 2020 11:32:54 +0100 [thread overview]
Message-ID: <3934e35d-14ad-7709-2fff-9c5d48cf1896@proxmox.com> (raw)
In-Reply-To: <20201120132753.20966-1-a.lauterer@proxmox.com>
On 20.11.20 14:27, Aaron Lauterer wrote:
> This patch series introduces a "first welcome screen" shown on first
> start.
>
> Additionally, a class that stores the proxmox corporate identity (CI)
> colors is introduced.
>
> Changes to v1:
> * rework welcome screens, mainly use buttons instead of text links
> * cleanup code
> * use async where needed
> * fix image sizes for added logo
>
> Aaron Lauterer (3):
> add class for Proxmox corporate identity colors
> add Proxmox symbol logo white orange
> Add first welcome screen
>
Can you re-check the layout also a bit when running it as desktop application?
Not a complete deal breaker but would be nice to get that layout a bit more fitting
there too:
# flutter run -d linux
Besides that, for the actual use case it looks quite nice, great work!
Would like to still take a closer look at the code.
prev parent reply other threads:[~2020-12-10 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 13:27 Aaron Lauterer
2020-11-20 13:27 ` [pve-devel] [PATCH pve_flutter_frontend v2 1/3] add class for Proxmox corporate identity colors Aaron Lauterer
2020-11-20 13:27 ` [pve-devel] [PATCH pve_flutter_frontend v2 2/3] add Proxmox symbol logo white orange Aaron Lauterer
2020-11-20 13:27 ` [pve-devel] [PATCH pve_flutter_frontend v2 3/3] Add first welcome screen Aaron Lauterer
2020-12-10 10:32 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3934e35d-14ad-7709-2fff-9c5d48cf1896@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox