From: Lukas Wagner <l.wagner@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit v2] notify: sendmail: smtp: fix mailto/mailto-user parameter deletion
Date: Thu, 4 Jan 2024 14:01:37 +0100 [thread overview]
Message-ID: <39280e58-8b01-4007-b5ff-9ac39a76e247@proxmox.com> (raw)
In-Reply-To: <8d9113ea-863e-476b-93cf-4c9e87d527fb@proxmox.com>
On 1/4/24 13:41, Fiona Ebner wrote:
>
> Worked for me too :)
>
> However, I noticed that there were already cbinds for deleteEmpty for
> the mailto/mailto-user fields and wondered why that didn't have an
> effect. Turns out, it's because they're nested in another widget and
> that requires an additional cbind.
>
> Alternative patch with that approach sent here:
> https://lists.proxmox.com/pipermail/pve-devel/2024-January/061217.html
I think your approach is the better solution for this problem, my
patch can be ignored.
--
- Lukas
prev parent reply other threads:[~2024-01-04 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 8:50 Lukas Wagner
2024-01-04 12:41 ` Fiona Ebner
2024-01-04 13:01 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39280e58-8b01-4007-b5ff-9ac39a76e247@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox