From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH manager v2] fix #5106: ui: ceph status: make column wrap the summary text on expand
Date: Mon, 19 Feb 2024 15:07:58 +0100 [thread overview]
Message-ID: <38db552a-f761-4843-8cc7-c58c0913fb5f@proxmox.com> (raw)
In-Reply-To: <589fa91d-13c1-412d-b991-e3b338f0549d@proxmox.com>
Am 19/02/2024 um 14:59 schrieb Dominik Csapak:
> On 2/19/24 14:57, Thomas Lamprecht wrote:
>> btw. I first tried `pve-eslint --fix .` inside the (clean) www/manager6
>> folder, but that just resulted in a truncated ceph/Status.js file, so while
>> eslint seems to correctly get the fix option and finds the issue, writing
>> out the updated code to the file seems broken – can you look into that?
>> (no pressure though)
>
> i guess you meant me with that ;)
yeah, with you being the only person in the address To field and basically
main pve-eslint dev here that's a good guess ;-P But sure, an explicitly
@mention surely wouldn't have hurt, I will try to do add that next time too.
> yes i can look into that
thx!
prev parent reply other threads:[~2024-02-19 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 13:35 [pve-devel] " Dominik Csapak
2024-02-19 13:28 ` Fiona Ebner
2024-02-19 13:57 ` [pve-devel] applied: " Thomas Lamprecht
2024-02-19 13:59 ` Dominik Csapak
2024-02-19 14:07 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38db552a-f761-4843-8cc7-c58c0913fb5f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox