From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 edk2-firmware] fix #4625: restore SMBIOS type 0 table defaults
Date: Tue, 4 Apr 2023 16:10:37 +0200 [thread overview]
Message-ID: <38d729f4-0547-4d21-0681-3b26ded355a8@proxmox.com> (raw)
In-Reply-To: <20230330110134.322162-1-f.ebner@proxmox.com>
Am 30/03/2023 um 13:01 schrieb Fiona Ebner:
> Commit 4cb94f20b0 ("OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*") in
> the edk2 submodule made the switch from hard coded values for the
> SMBIOS type 0 table to using those defined in the PCD (Platform
> Configuration Database). But this changed the value for the vendor
> from "EFI Development Kit II / OVMF" to "EDK II" and made version and
> release date "unknown". This can cause problems for hardware keys[0],
> and the missing date can make Windows unhappy[1].
>
> The PCD information can be specified during build. For the vendor,
> just revert to the hardcoded value from before. This should be enough
> to resolve the issue in [0]. For version and date, use sensible values
> gathered from the build variables. The date format is mm/dd/yyyy while
> the version is free-form according to [2], section 7.1.
>
> [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=4625
> [1]: https://edk2.groups.io/g/devel/message/100922
> [2]: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.2.0.pdf
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Changes from v1:
> Based on the discussion in [3] and the fact that the user from bug
> #4625 reportet that it's enough to keep the vendor the same:
> * Add trailing null character to strings, just to be sure.
> * Set version and date to sensible values generated during build.
> This was the intention behind commit 4cb94f20b0 in the first
> place.
>
> [3]: https://edk2.groups.io/g/devel/message/102164
>
> debian/rules | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2023-04-04 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 11:01 [pve-devel] " Fiona Ebner
2023-04-04 14:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38d729f4-0547-4d21-0681-3b26ded355a8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox