public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Romain Lebbadi-Breteau <romain.lebbadi-breteau@polymtl.ca>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-installer] fix #5583: add dhclient options in kernel cmdline
Date: Tue, 17 Nov 2026 00:57:11 -0500	[thread overview]
Message-ID: <38668878-c441-4494-87c7-4c5ce8637344@polymtl.ca> (raw)

This applies the patch proposed in bug report #5583 
(https://bugzilla.proxmox.com/attachment.cgi?id=1421).
I built the proxmox-installer.deb package, extracted it in 
pve-installer.squashfs in a live ISO and tested
it in a virtual machine. The command-line arguments work as expected, 
and allow for a bigger timeout
especially when using a switch with STP.
Signed-off-by: Romain Lebbadi-Breteau <romain.lebbadi-breteau at polymtl.ca>
---
  unconfigured.sh | 43 ++++++++++++++++++++++++++++++++++++++++++-
  1 file changed, 42 insertions(+), 1 deletion(-)
diff --git a/unconfigured.sh b/unconfigured.sh
index 31fcfca..76b2d00 100755
--- a/unconfigured.sh
+++ b/unconfigured.sh
@@ -13,6 +13,16 @@parse_cmdline() {
      proxtui=0
      serial=0
      live_vlan_id=
+
+    # these are the original defaults from the stock proxmox dhclient.conf
+    dhclient_timeout=10
+    dhclient_initial_interval=3
+    dhclient_initial_delay=0
+    dhclient_select_timeout=0
+
+    # these are defaults from the dhclient.conf man page
+    dhclient_retry=300
+
      # shellcheck disable=SC2013 # per word splitting is wanted here
      for par in $(cat /proc/cmdline); do
          case $par in
@@ -31,10 +41,39 @@parse_cmdline() {
              proxmox-vlan=*)
                  live_vlan_id=${par#proxmox-vlan=}
              ;;
+            dhclient_timeout=*)
+                dhclient_timeout=${par#dhclient_timeout=}
+            ;;
+            dhclient_initial_interval=*)
+                dhclient_initial_interval=${par#dhclient_initial_interval=}
+            ;;
+            dhclient_initial_delay=*)
+                dhclient_initial_delay=${par#dhclient_initial_delay=}
+            ;;
+            dhclient_select_timeout=*)
+                dhclient_select_timeout=${par#dhclient_select_timeout=}
+            ;;
+            dhclient_retry=*)
+                dhclient_retry=${par#dhclient_retry=}
+            ;;
+
          esac
      done;
  }
+create_dhclient_conf() {
+    # create a new dhclient.conf file based on values from
+    # above, either defaults or read from cmdline
+    cat > /etc/dhcp/dhclient.conf <<EOF
+timeout ${dhclient_timeout};
+initial-interval ${dhclient_initial_interval};
+initial-delay ${dhclient_initial_delay};
+select-timeout ${dhclient_select_timeout};
+retry ${dhclient_retry};
+
+EOF
+}
+
  debugsh() {
      /bin/bash
  }
@@ -272,6 +311,8 @@mkdir -p /run/proxmox-installer
  parse_cmdline
+create_dhclient_conf
+
  # always load most common input drivers
  modprobe -q psmouse || true
  modprobe -q sermouse ||  true
@@ -451,7 +492,7 @@fi
  # just to be sure everything is on disk
  sync
-if [ $proxdebug -ne 0 ]; then
+if [ $proxdebug -ne 0 ]; then
      printf "\nDebug shell after installation exited (type exit or 
CTRL-D to reboot)\n"
      debugsh || true
  fi
-- 
2.43.0





                 reply	other threads:[~2026-11-17  6:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38668878-c441-4494-87c7-4c5ce8637344@polymtl.ca \
    --to=romain.lebbadi-breteau@polymtl.ca \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal