From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH container] fix #3424: vzdump: cleanup: wait for active replication
Date: Fri, 14 Jan 2022 13:21:19 +0100 [thread overview]
Message-ID: <38476974-2ebb-e0e1-af58-600a8777e34a@proxmox.com> (raw)
In-Reply-To: <20220114115521.43773-1-f.ebner@proxmox.com>
On 14.01.22 12:55, Fabian Ebner wrote:
> As replication and backup can happen at the same time, the vzdump
> snapshot might be actively used by replication when backup tries
> to cleanup, resulting in a not (or only partially) removed snapshot
> and locked (snapshot-delete) container.
>
> Wait up to 10 minutes for any ongoing replication. If replication
> doesn't finish in time, the fact that there is no attempt to remove
> the snapshot means that there's no risk for the container to end up in
> a locked state. And the beginning of the next backup will force remove
> the left-over snapshot, which will very likely succeed even at the
> storage layer, because the replication really should be done by then
> (subsequent replications shouldn't matter as they don't need to
> re-transfer the vzdump snapshot).
>
> Suggested-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> VM backups are not affected by this, because they don't use
> storage/config snapshots, but use pve-qemu's block layer.
>
> Decided to go for this approach rather than replication waiting on
> backup, because "full backup can take much longer than replication
> usually does", and even if we time out, we can just skip the removal
> for now and have the next backup do it.
>
> src/PVE/VZDump/LXC.pm | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm
> index b7f7463..10edae9 100644
> --- a/src/PVE/VZDump/LXC.pm
> +++ b/src/PVE/VZDump/LXC.pm
> @@ -8,6 +8,7 @@ use File::Path;
> use POSIX qw(strftime);
>
> use PVE::Cluster qw(cfs_read_file);
> +use PVE::GuestHelpers;
> use PVE::INotify;
> use PVE::LXC::Config;
> use PVE::LXC;
> @@ -476,8 +477,14 @@ sub cleanup {
> }
>
> if ($task->{cleanup}->{remove_snapshot}) {
> - $self->loginfo("cleanup temporary 'vzdump' snapshot");
> - PVE::LXC::Config->snapshot_delete($vmid, 'vzdump', 0);
> + $self->loginfo("checking/waiting for replication..");
do we know if replication is setup at this stage? as I'd like to avoid
logging that if that's not the case to avoid user confusion.
> + eval {
> + PVE::GuestHelpers::guest_migration_lock($vmid, 600, sub {
> + $self->loginfo("cleanup temporary 'vzdump' snapshot");
> + PVE::LXC::Config->snapshot_delete($vmid, 'vzdump', 0);
> + });
> + };
> + die "snapshot 'vzdump' was not (fully) removed - $@" if $@;
> }
> }
>
next prev parent reply other threads:[~2022-01-14 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 11:55 Fabian Ebner
2022-01-14 12:21 ` Thomas Lamprecht [this message]
2022-01-14 12:39 ` Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38476974-2ebb-e0e1-af58-600a8777e34a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox