Re: [PATCH manager v2] fix #7896: ui: qemu: show effective machine version for Windows guests

[Dominik Csapak <d.csapak@proxmox.com>]

one comment inline

On 8/24/26 3:01 PM, Jakob Klocker wrote:
[snip]
>               q35: (get) => get('type') === 'q35',
> @@ -102,10 +104,21 @@ Ext.define('PVE.qemu.MachineInputPanel', {
>           }
>   
>           if (me.isWindows) {
> -            if (values.machine === '__default__') {
> -                values.version = 'pc-i440fx-5.1';
> -            } else if (values.machine === 'q35') {
> -                values.version = 'pc-q35-5.1';
> +            if (values.machine === '__default__' || values.machine === 'q35') {
> +                let effective = PVE.Utils.qemu_implicit_machine_version(
> +                    values.machine,
> +                    values.creationQemu,
> +                    values.arch,
> +                );
> +                me.getViewModel().set({
> +                    effectiveVersionLabel: effective + ' ' + gettext('(implicit)'),
> +                    implicitVersion: true,
> +                });
> +                me.setAdvancedVisible(true);


> +                // flush the binding, then re-baseline the reset value to it
> +                // otherwise the Reset button reverts to the field's empty initial value
> +                me.getViewModel().notify();
> +                me.lookup('effectiveVersion').resetOriginalValue();

under which circumstances is this necessary?

even with those two statements deleted, i can't trigger it to have
the reset button enabled?

in general, we probably shouldn't mess with the 'resetOriginalValue' too
much, but if we do, having the steps where this is necessary
would be good (does not have to be a comment, in the commit message is
fine for me)