public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 manager 0/2] ui: ceph: improve discoverability of warning details
Date: Wed, 8 Mar 2023 17:38:24 +0100	[thread overview]
Message-ID: <380337b9-49aa-7fb6-3e29-8f751f6aa2be@proxmox.com> (raw)
In-Reply-To: <82701573-4e32-550a-7842-d7b2b815754f@proxmox.com>



On 3/8/23 17:05, Thomas Lamprecht wrote:
> Am 08/03/2023 um 13:09 schrieb Aaron Lauterer:
>> The goal for this small series is to make it easier/more obvious to see
>> that there are potentially more details for a warning ceph is showing
>> by:
>> * having a tooltip with the details (limited in length)
>> * making the detail/info button more visible
>>
> 
> One bug I see is that if I open the detail window, the next extjs (probably store)
> refresh seemingly refocuses the some part of the row and then the tooltip pops up
> too for the element I'm already having the full detail window open.

Thanks for catching that! :-/

> 
> That said, why not avoid the tooltip but inline the info by moving the severity to
> the right, dropping the info button completely and making the grid row expandable,
> i.e., like the PMG tracking center grid does?

We thought about it, but initially I wasn't too happy about it, because if the 
detailed error message has many lines and/or long lines, it would be nicer to 
just open the window and making it as large as possible.
With the expandable row, the visible area can be rather small.

But with that unfortunate behavior with the detail window opened, I am more 
inclined to make the rows expandable.

I'll give it a try and will send a v4 :)

> 
> Would feel more integrated and less duplicate (tooltip + detail window)
> information.




  reply	other threads:[~2023-03-08 16:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 12:09 Aaron Lauterer
2023-03-08 12:09 ` [pve-devel] [PATCH v3 manager 1/2] ui: ceph: make the warning detail button stand out more Aaron Lauterer
2023-03-08 12:09 ` [pve-devel] [PATCH v3 manager 2/2] ui: ceph status: add tooltip with details to warnings Aaron Lauterer
2023-03-08 16:05 ` [pve-devel] [PATCH v3 manager 0/2] ui: ceph: improve discoverability of warning details Thomas Lamprecht
2023-03-08 16:38   ` Aaron Lauterer [this message]
2023-03-08 16:43     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=380337b9-49aa-7fb6-3e29-8f751f6aa2be@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal